mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-11 05:55:33 +00:00
Code Issues Projects Releases Wiki Activity

Normal (generator): micro optimisations (and readability improvements)

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-10-17 19:24:01 +01:00
parent 0f9d5f7011
commit 095449e86a
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/world/generator/normal/Normal.php
View File

@ -158,13 +158,17 @@ class Normal extends Generator{
$stillWater = VanillaBlocks::WATER()->getFullId(); $stillWater = VanillaBlocks::WATER()->getFullId();
$stone = VanillaBlocks::STONE()->getFullId(); $stone = VanillaBlocks::STONE()->getFullId();
$baseX = $chunkX * 16;
$baseZ = $chunkZ * 16;
for($x = 0; $x < 16; ++$x){ for($x = 0; $x < 16; ++$x){
$absoluteX = $baseX + $x;
for($z = 0; $z < 16; ++$z){ for($z = 0; $z < 16; ++$z){
$absoluteZ = $baseZ + $z;
$minSum = 0; $minSum = 0;
$maxSum = 0; $maxSum = 0;
$weightSum = 0; $weightSum = 0;
$biome = $this->pickBiome($chunkX * 16 + $x, $chunkZ * 16 + $z); $biome = $this->pickBiome($absoluteX, $absoluteZ);
$chunk->setBiomeId($x, $z, $biome->getId()); $chunk->setBiomeId($x, $z, $biome->getId());
for($sx = -$this->gaussian->smoothSize; $sx <= $this->gaussian->smoothSize; ++$sx){ for($sx = -$this->gaussian->smoothSize; $sx <= $this->gaussian->smoothSize; ++$sx){
@ -175,11 +179,11 @@ class Normal extends Generator{
if($sx === 0 and $sz === 0){ if($sx === 0 and $sz === 0){
$adjacent = $biome; $adjacent = $biome;
}else{ }else{
$index = World::chunkHash($chunkX * 16 + $x + $sx, $chunkZ * 16 + $z + $sz); $index = World::chunkHash($absoluteX + $sx, $absoluteZ + $sz);
if(isset($biomeCache[$index])){ if(isset($biomeCache[$index])){
$adjacent = $biomeCache[$index]; $adjacent = $biomeCache[$index];
}else{ }else{
$biomeCache[$index] = $adjacent = $this->pickBiome($chunkX * 16 + $x + $sx, $chunkZ * 16 + $z + $sz); $biomeCache[$index] = $adjacent = $this->pickBiome($absoluteX + $sx, $absoluteZ + $sz);
} }
} }