mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-10 21:45:35 +00:00
Code Issues Projects Releases Wiki Activity

PluginLoadabilityChecker: fixed logic of extension compatibility check

Browse Source 
if the extension doesn't specify any version, we can't do any constraint other than *.
This commit is contained in:
Dylan K. Taylor 2021-12-08 20:08:53 +00:00
parent 3d9e19546f
commit 0793e7e094
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugin/PluginLoadabilityChecker.php
View File

@ -30,6 +30,7 @@ use pocketmine\utils\Utils;
use pocketmine\utils\VersionString; use pocketmine\utils\VersionString;
use function array_intersect; use function array_intersect;
use function count; use function count;
use function extension_loaded;
use function implode; use function implode;
use function in_array; use function in_array;
use function phpversion; use function phpversion;
@ -77,9 +78,13 @@ final class PluginLoadabilityChecker{
} }
foreach(Utils::stringifyKeys($description->getRequiredExtensions()) as $extensionName => $versionConstrs){ foreach(Utils::stringifyKeys($description->getRequiredExtensions()) as $extensionName => $versionConstrs){
if(!extension_loaded($extensionName)){
return KnownTranslationFactory::pocketmine_plugin_extensionNotLoaded($extensionName);
}
$gotVersion = phpversion($extensionName); $gotVersion = phpversion($extensionName);
if($gotVersion === false){ if($gotVersion === false){
return KnownTranslationFactory::pocketmine_plugin_extensionNotLoaded($extensionName); //extensions may set NULL as the extension version, in which case phpversion() may return false
$gotVersion = "**UNKNOWN**";
} }
foreach($versionConstrs as $k => $constr){ // versionConstrs_loop foreach($versionConstrs as $k => $constr){ // versionConstrs_loop