mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-16 03:51:37 +00:00
Code Issues Projects Releases Wiki Activity

PrepareEncryptionTask: verify client key before entering task

Browse Source 
this ensures that whoever's giving invalid keys to the task gets properly blamed
This commit is contained in:
Dylan K. Taylor
2025-10-04 12:48:29 +01:00
parent 24567dac54
commit 05a71d8cc5
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/mcpe/encryption/PrepareEncryptionTask.php
View File

@@ -51,6 +51,9 @@ class PrepareEncryptionTask extends AsyncTask{
private string $clientPub, private string $clientPub,
\Closure $onCompletion \Closure $onCompletion
){ ){
//make sure the key is valid before we break the stack trace
//TODO: maybe in the future we should require OpenSSLAsymmetricKey here instead of string
JwtUtils::parseDerPublicKey($this->clientPub);
if(self::$SERVER_PRIVATE_KEY === null){ if(self::$SERVER_PRIVATE_KEY === null){
$serverPrivateKey = openssl_pkey_new(["ec" => ["curve_name" => "secp384r1"]]); $serverPrivateKey = openssl_pkey_new(["ec" => ["curve_name" => "secp384r1"]]);
if($serverPrivateKey === false){ if($serverPrivateKey === false){