mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 08:44:01 +00:00
Code Issues Projects Releases Wiki Activity

Fix setting item custom name does not update inventory

Browse Source 
If a NamedTag was already present, it was modifying the object directly
WITHOUT serializing the tag back to raw NBT for sending. This commit
fixes that by always serializing the tag on change.
This commit is contained in:
Dylan K. Taylor 2017-01-10 00:38:23 +00:00
parent b566c4e609
commit 058468104a
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/item/Item.php
View File

@ -559,7 +559,7 @@ class Item implements ItemIds, \JsonSerializable{
$this->clearCustomName();
}
if(!($hadCompoundTag = $this->hasCompoundTag())){
if($this->hasCompoundTag()){
$tag = new CompoundTag("", []);
}else{
$tag = $this->getNamedTag();
@ -573,9 +573,7 @@ class Item implements ItemIds, \JsonSerializable{
]);
}
if(!$hadCompoundTag){
$this->setCompoundTag($tag);
}
return $this;
}