mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-22 19:06:35 +00:00
Code Issues Projects Releases Wiki Activity

Add specialized entityBaseTick timer for item entities

Browse Source 
since item merging is a potential hotspot, we want to know if this code section is a performance problem.
Current timers only tell us whether overall ticking of a particular entity is slow, but that includes movement and therefore isn't particularly helpful.
This commit is contained in:
Dylan K. Taylor 2023-03-19 15:59:06 +00:00
parent 7bc5d8c824
commit 054c06fab9
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
2 changed files with 48 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/entity/object/ItemEntity.php
View File

@ -41,6 +41,7 @@ use pocketmine\network\mcpe\protocol\AddItemActorPacket;
use pocketmine\network\mcpe\protocol\types\entity\EntityIds; use pocketmine\network\mcpe\protocol\types\entity\EntityIds;
use pocketmine\network\mcpe\protocol\types\inventory\ItemStackWrapper; use pocketmine\network\mcpe\protocol\types\inventory\ItemStackWrapper;
use pocketmine\player\Player; use pocketmine\player\Player;
use pocketmine\timings\Timings;
use function max; use function max;
class ItemEntity extends Entity{ class ItemEntity extends Entity{
@ -113,6 +114,9 @@ class ItemEntity extends Entity{
return false; return false;
} }
Timings::$itemEntityBaseTick->startTiming();
try{
$hasUpdate = parent::entityBaseTick($tickDiff); $hasUpdate = parent::entityBaseTick($tickDiff);
if($this->isFlaggedForDespawn()){ if($this->isFlaggedForDespawn()){
@ -164,6 +168,9 @@ class ItemEntity extends Entity{
} }
return $hasUpdate; return $hasUpdate;
}finally{
Timings::$itemEntityBaseTick->stopTiming();
}
} }
/** /**

3
src/timings/Timings.php
View File

@ -107,6 +107,8 @@ abstract class Timings{
/** @var TimingsHandler */ /** @var TimingsHandler */
public static $livingEntityBaseTick; public static $livingEntityBaseTick;
public static TimingsHandler $itemEntityBaseTick;
/** @var TimingsHandler */ /** @var TimingsHandler */
public static $schedulerSync; public static $schedulerSync;
/** @var TimingsHandler */ /** @var TimingsHandler */
@ -200,6 +202,7 @@ abstract class Timings{
self::$entityBaseTick = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Entity Base Tick"); self::$entityBaseTick = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Entity Base Tick");
self::$livingEntityBaseTick = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Entity Base Tick - Living"); self::$livingEntityBaseTick = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Entity Base Tick - Living");
self::$itemEntityBaseTick = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Entity Base Tick - ItemEntity");
self::$schedulerSync = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Scheduler - Sync Tasks"); self::$schedulerSync = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Scheduler - Sync Tasks");
self::$schedulerAsync = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Scheduler - Async Tasks"); self::$schedulerAsync = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Scheduler - Async Tasks");