From 04bdb1310353a4938fb51b9874da37593c144d88 Mon Sep 17 00:00:00 2001 From: Shoghi Cervantes Date: Fri, 2 Jan 2015 19:14:18 +0100 Subject: [PATCH] Improved move offset check --- src/pocketmine/CrashDump.php | 2 +- src/pocketmine/command/CommandReader.php | 2 +- src/pocketmine/entity/Entity.php | 4 ++-- src/pocketmine/level/generator/Flat.php | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/pocketmine/CrashDump.php b/src/pocketmine/CrashDump.php index cbd419397..39a8b4c61 100644 --- a/src/pocketmine/CrashDump.php +++ b/src/pocketmine/CrashDump.php @@ -137,7 +137,7 @@ class CrashDump{ $error = $lastExceptionError; }else{ $error = (array) error_get_last(); - $error["trace"] = @getTrace(4); + $error["trace"] = @getTrace(3); $errorConversion = [ E_ERROR => "E_ERROR", E_WARNING => "E_WARNING", diff --git a/src/pocketmine/command/CommandReader.php b/src/pocketmine/command/CommandReader.php index 076f14166..076f868fe 100644 --- a/src/pocketmine/command/CommandReader.php +++ b/src/pocketmine/command/CommandReader.php @@ -34,7 +34,7 @@ class CommandReader extends Thread{ */ public function __construct(\Threaded $threaded){ $this->buffer = $threaded; - $this->start(PTHREADS_INHERIT_NONE); + $this->start(); } private function readLine(){ diff --git a/src/pocketmine/entity/Entity.php b/src/pocketmine/entity/Entity.php index f50b496a8..b4f8ae44f 100644 --- a/src/pocketmine/entity/Entity.php +++ b/src/pocketmine/entity/Entity.php @@ -877,7 +877,7 @@ abstract class Entity extends Location implements Metadatable{ //TODO: big messy loop }*/ - $list = $this->level->getCollisionCubes($this, $this->boundingBox->addCoord($dx, $dy, $dz)); + $list = $this->level->getCollisionCubes($this, $this->boundingBox->getOffsetBoundingBox($dx, $dy, $dz)); foreach($list as $bb){ @@ -931,7 +931,7 @@ abstract class Entity extends Location implements Metadatable{ $this->boundingBox->setBB($axisalignedbb); - $list = $this->level->getCollisionCubes($this, $this->boundingBox->addCoord($dx, $dy, $dz), false); + $list = $this->level->getCollisionCubes($this, $this->boundingBox->getOffsetBoundingBox($dx, $dy, $dz), false); foreach($list as $bb){ $dy = $bb->calculateYOffset($this->boundingBox, $dy); diff --git a/src/pocketmine/level/generator/Flat.php b/src/pocketmine/level/generator/Flat.php index 626e01c1d..f2ab171ba 100644 --- a/src/pocketmine/level/generator/Flat.php +++ b/src/pocketmine/level/generator/Flat.php @@ -84,7 +84,7 @@ class Flat extends Generator{ $this->preset = $preset; $preset = explode(";", $preset); $version = (int) $preset[0]; - $blocks = @$preset[1]; + $blocks = isset($preset[1]) ? $preset[1] : ""; $biome = isset($preset[2]) ? $preset[2] : 1; $options = isset($preset[3]) ? $preset[3] : ""; preg_match_all('#(([0-9]{0,})x?([0-9]{1,3}:?[0-9]{0,2})),?#', $blocks, $matches);