mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-21 08:17:34 +00:00
Code Issues Projects Releases Wiki Activity

TaskScheduler: Remove repeating tasks which throw exceptions

Browse Source
This commit is contained in:
Dylan K. Taylor 2018-05-31 14:10:59 +01:00
parent 6b4b4e4bb1
commit 02b4eeeb9b
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/pocketmine/scheduler/TaskScheduler.php
View File

@ -198,19 +198,26 @@ class TaskScheduler{
unset($this->tasks[$task->getTaskId()]);
continue;
}
$crashed = false;
try{
$task->run($this->currentTick);
}catch(\Throwable $e){
$crashed = true;
$this->logger->critical("Could not execute task " . $task->getTaskName() . ": " . $e->getMessage());
$this->logger->logException($e);
}
if($task->isRepeating()){
$task->setNextRun($this->currentTick + $task->getPeriod());
$this->queue->insert($task, $this->currentTick + $task->getPeriod());
}else{
$task->remove();
unset($this->tasks[$task->getTaskId()]);
if($crashed){
$this->logger->debug("Dropping repeating task " . $task->getTaskName() . " due to exceptions thrown while running");
}else{
$task->setNextRun($this->currentTick + $task->getPeriod());
$this->queue->insert($task, $this->currentTick + $task->getPeriod());
continue;
}
}
$task->remove();
unset($this->tasks[$task->getTaskId()]);
}
}