From 01d6cbe9c32b0f553354eb23ac84a117db6aff5d Mon Sep 17 00:00:00 2001 From: Stephen Date: Thu, 21 Nov 2019 15:01:34 -0500 Subject: [PATCH] Added : void typehint to SkinAdapterSingleton & provide documentation --- .../network/mcpe/protocol/types/SkinAdapter.php | 15 +++++++++++++++ .../mcpe/protocol/types/SkinAdapterSingleton.php | 7 +++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/network/mcpe/protocol/types/SkinAdapter.php b/src/pocketmine/network/mcpe/protocol/types/SkinAdapter.php index 7904917fb..56b940063 100644 --- a/src/pocketmine/network/mcpe/protocol/types/SkinAdapter.php +++ b/src/pocketmine/network/mcpe/protocol/types/SkinAdapter.php @@ -25,9 +25,24 @@ namespace pocketmine\network\mcpe\protocol\types; use pocketmine\entity\Skin; +/** + * Used to convert new skin data to the skin entity or old skin entity to skin data. + */ interface SkinAdapter{ + /** + * Allows you to convert a skin entity to skin data. + * + * @param Skin $skin + * @return SkinData + */ public function toSkinData(Skin $skin) : SkinData; + /** + * Allows you to convert skin data to a skin entity. + * + * @param SkinData $data + * @return Skin + */ public function fromSkinData(SkinData $data) : Skin; } \ No newline at end of file diff --git a/src/pocketmine/network/mcpe/protocol/types/SkinAdapterSingleton.php b/src/pocketmine/network/mcpe/protocol/types/SkinAdapterSingleton.php index 38a928e6e..b75f228b3 100644 --- a/src/pocketmine/network/mcpe/protocol/types/SkinAdapterSingleton.php +++ b/src/pocketmine/network/mcpe/protocol/types/SkinAdapterSingleton.php @@ -23,8 +23,11 @@ declare(strict_types=1); namespace pocketmine\network\mcpe\protocol\types; +/** + * Accessor for SkinAdapter +*/ class SkinAdapterSingleton{ - + /** @var SkinAdapter|null */ private static $skinAdapter = null; public static function get() : SkinAdapter{ @@ -34,7 +37,7 @@ class SkinAdapterSingleton{ return self::$skinAdapter; } - public static function set(SkinAdapter $adapter){ + public static function set(SkinAdapter $adapter) : void{ self::$skinAdapter = $adapter; } } \ No newline at end of file