try_user
2.0
If following the style of the rest of the repository, we should exclude this else:
else:
@@ -355,0 +385,4 @@
await self.populate_owners()
return await self.try_owners()
async def populate_owners(self):
If owners have not been loaded this will return None
None
Other than this and some code styling it looks good Please space out the code a bit, everything is so cramped
@@ -827,6 +827,38 @@ class Client:
"""
return self._connection.get_user(id)
async def try_user(self, id: int, /) -> Optional[User]:
Missing versionadded
I would maybe return the owners here
Return type wouldn't really be consistent or useful imo.
not returning the owners is fine
LGTM
No dependencies set.
The note is not visible to the blocked user.
Summary
If following the style of the rest of the repository, we should exclude this
else:@@ -355,0 +385,4 @@await self.populate_owners()return await self.try_owners()async def populate_owners(self):If owners have not been loaded this will return
NoneOther than this and some code styling it looks good
Please space out the code a bit, everything is so cramped
@@ -827,6 +827,38 @@ class Client:"""return self._connection.get_user(id)async def try_user(self, id: int, /) -> Optional[User]:Missing versionadded
I would maybe return the owners here
Return type wouldn't really be consistent or useful imo.
not returning the owners is fine
LGTM