Utilities and JSON Database support #51

2021-09-02T17:43:30Z

ghost commented

2021-09-02 17:43:30 +00:00

(Migrated from github.com)

Summary

I added utilities and simplified some code. I also added a base to color support, so you can pass in hexidecimal values in a Colour object. My friend and maintainer of EDPY dank Had0cK helped me with some utilities, thank you!

Feel free to comment on things I could have done, and change the code accordingly(to maintainers).

This is the first pull request I have made, so please tell me about anything I could have improved.

Most documentation is in code(like with """""").

Checklist

If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)

## Summary I added utilities and simplified some code. I also added a base to color support, so you can pass in hexidecimal values in a Colour object. My friend and maintainer of EDPY dank Had0cK helped me with some utilities, thank you! Feel free to comment on things I could have done, and change the code accordingly(to maintainers). This is the first pull request I have made, so please tell me about anything I could have improved. Most documentation is in code(like with """"""). ## Checklist  - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [x] This PR fixes an issue. - [x] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)

Gnome-py commented

2021-09-02 17:49:18 +00:00

(Migrated from github.com)

All of this is either:

Out of scope for the project (the JSON stuff)
Random changes that don't help (changing x is None to not x)
Completely random (why can't users just make their own Embed instances)

The docstrings also do not follow the same format as the rest of the lib, causing docs to most likely fail to build.

All of this is either: - Out of scope for the project (the JSON stuff) - Random changes that don't help (changing `x is None` to `not x`) - Completely random (why can't users just make their own `Embed` instances) The docstrings also do not follow the same format as the rest of the lib, causing docs to most likely fail to build.

ghost commented

2021-09-02 17:49:23 +00:00

(Migrated from github.com)

Sorry about the JSON DB thing(discord/ext/json), Just realized how slow it is. to remove it, remove discord/ext/json, sorry

Daggy1234 commented

2021-09-02 17:52:56 +00:00

(Migrated from github.com)

Color already supports hexadecimal values, prefix with 0x and they work? String parsing is a bad idea. Also json extension is a dumb idea, please use databases.

Color already supports hexadecimal values, prefix with 0x and they work? String parsing is a bad idea. Also json extension is a dumb idea, please use databases. <img width="504" alt="image" src="https://user-images.githubusercontent.com/60603110/131892990-82742001-35c6-4048-9763-98d2442224f9.png">

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#51