matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Utilities and JSON Database support #51

Closed
ghost wants to merge 6 commits from 2.0 into 2.0
pull from: 2.0
merge into: matthew:2.0
Conversation 3 Commits 6 Files Changed 10 +263 -7
ghost commented 2021-09-02 17:43:30 +00:00 (Migrated from github.com)
Copy Link

Summary

I added utilities and simplified some code. I also added a base to color support, so you can pass in hexidecimal values in a Colour object. My friend and maintainer of EDPY dank Had0cK helped me with some utilities, thank you!

Feel free to comment on things I could have done, and change the code accordingly(to maintainers).

This is the first pull request I have made, so please tell me about anything I could have improved.

Most documentation is in code(like with """""").

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
## Summary I added utilities and simplified some code. I also added a base to color support, so you can pass in hexidecimal values in a Colour object. My friend and maintainer of EDPY dank Had0cK helped me with some utilities, thank you! Feel free to comment on things I could have done, and change the code accordingly(to maintainers). This is the first pull request I have made, so please tell me about anything I could have improved. Most documentation is in code(like with """"""). ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [x] This PR fixes an issue. - [x] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
Gnome-py commented 2021-09-02 17:49:18 +00:00 (Migrated from github.com)
Copy Link

All of this is either:

  • Out of scope for the project (the JSON stuff)
  • Random changes that don't help (changing x is None to not x)
  • Completely random (why can't users just make their own Embed instances)

The docstrings also do not follow the same format as the rest of the lib, causing docs to most likely fail to build.

All of this is either: - Out of scope for the project (the JSON stuff) - Random changes that don't help (changing `x is None` to `not x`) - Completely random (why can't users just make their own `Embed` instances) The docstrings also do not follow the same format as the rest of the lib, causing docs to most likely fail to build.
ghost commented 2021-09-02 17:49:23 +00:00 (Migrated from github.com)
Copy Link

Sorry about the JSON DB thing(discord/ext/json), Just realized how slow it is. to remove it, remove discord/ext/json, sorry

Sorry about the JSON DB thing(discord/ext/json), Just realized how slow it is. to remove it, remove discord/ext/json, sorry
Daggy1234 commented 2021-09-02 17:52:56 +00:00 (Migrated from github.com)
Copy Link

Color already supports hexadecimal values, prefix with 0x and they work? String parsing is a bad idea. Also json extension is a dumb idea, please use databases.

image
Color already supports hexadecimal values, prefix with 0x and they work? String parsing is a bad idea. Also json extension is a dumb idea, please use databases. <img width="504" alt="image" src="https://user-images.githubusercontent.com/60603110/131892990-82742001-35c6-4048-9763-98d2442224f9.png">

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#51
No description provided.
Delete Branch "2.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?