Apparently the clever hack for logging in on_error was not so clever
after all. If logging isn't configured, by the logging modules
definition of not configured, which is root logger not having an
Handlers attached, it will call logging.basicConfig(). Which messes up
setups that define handlers for other loggers than the root logger.
Going directly to the root logger rather than using the broken
convenience methods for logger is not an option either, as logger before
Python 3.2 does not have lastResort on the root logger, and prints an
error when invoked without any handlers.
Resolve by printing tracebacks to stderr by default in on_error.
Change the default implementation of on_error to log to the root logger
instead of discord.client and clarify that the exception is being
ignored. This ensures that a message will be output to standard error
in case the logging module has not been configured.
Also removes the argument printing for the default on_error, this is due
to them often being too long, that they could cause another exception to
be thrown, and because it sometimes causes sensitive information to be
output such as Discord tokens and session ids. It was also possible for
the length to get in the megabyte range with exceptions thrown by
on_socket_raw_receive in READY events.
Add on_socket_raw_receive and on_socket_raw_send events for sniffing the
data being received and sent on the websocket. Useful for debugging and
logging websocket messages received and sent on the link to Discord's
servers.
This adds a lot of new attributes into the Member class
such as giving a voice_channel that the user is currently connected
to. Initially there was a plan to have a voice_members attribute
in the Channel class but this proved to be difficult when it came to
actually removing users from the voice channel as the response would
return channel_id as null.
Fixes#16.
Documented the new way of listening to events as well the new
events that could be listened thanks to the recent refactor.
Also uses the versionadded directive to document when something new
is added to the library.
Change the description of on_error to reflect that exceptions are logged
and not output by default. Add a note about not configuring logging
causing exceptions to be silently ignored in handlers in the API. And
add some more explanations and a simpler configuration example to the
logging description.
Without setting up the logging module, a god number of error conditions
and warnings will never be output by the library. This is a common
pitfall to forget and it's not documented good enough the consequences
of not setting up the logging module when developing applications with
this library.
Check and handle login failure in the examples provided for using this
library. This is a common error condition that should be handled by any
script using this library.
