From f37be7961a05e76d0cda3fc76c6bc79bdcc3c52d Mon Sep 17 00:00:00 2001 From: Ahmad Ansori Palembani <46041660+null2264@users.noreply.github.com> Date: Fri, 3 Sep 2021 02:46:56 +0700 Subject: [PATCH] Merge pull request #41 * Fixed `TypeError` * Handles `EmptyEmbed` inside setter instead of set_ * Remove return and setter docstring --- discord/embeds.py | 38 +++++++++++++++++--------------------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/discord/embeds.py b/discord/embeds.py index 25f05aef..41f2be40 100644 --- a/discord/embeds.py +++ b/discord/embeds.py @@ -404,10 +404,13 @@ class Embed: return EmbedProxy(getattr(self, '_image', {})) # type: ignore @image.setter - def image(self: E, *, url: Any): - self._image = { - 'url': str(url), - } + def image(self: E, url: Any): + if url is EmptyEmbed: + del self._image + else: + self._image = { + 'url': str(url), + } @image.deleter def image(self: E): @@ -431,10 +434,7 @@ class Embed: The source URL for the image. Only HTTP(S) is supported. """ - if url is EmptyEmbed: - del self.image - else: - self.image = url + self.image = url return self @@ -454,15 +454,13 @@ class Embed: return EmbedProxy(getattr(self, '_thumbnail', {})) # type: ignore @thumbnail.setter - def thumbnail(self: E, *, url: Any): - """Sets the thumbnail for the embed content. - """ - - self._thumbnail = { - 'url': str(url), - } - - return + def thumbnail(self: E, url: Any): + if url is EmptyEmbed: + del self._thumbnail + else: + self._thumbnail = { + 'url': str(url), + } @thumbnail.deleter def thumbnail(self): @@ -485,10 +483,8 @@ class Embed: url: :class:`str` The source URL for the thumbnail. Only HTTP(S) is supported. """ - if url is EmptyEmbed: - del self.thumbnail - else: - self.thumbnail = url + + self.thumbnail = url return self