matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Make more things into properties.

Browse Source 
A lot of the expensive getters were transformed into cached properties
instead. A lot of things that were properties were transformed into
properties as well.
This commit is contained in:
Rapptz
2015-12-16 22:03:16 -05:00
parent f484a5c023
commit de1c74a399
5 changed files with 34 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
discord/server.py
View File

@@ -108,12 +108,11 @@ class Server(EqualityComparable):
self.unavailable = guild.get('unavailable', False)
self.id = guild['id']
self.roles = [Role(everyone=(self.id == r['id']), **r) for r in guild['roles']]
default_role = self.get_default_role()
owner_id = guild['owner_id']
for data in guild.get('members', []):
roles = [default_role]
roles = [self.default_role]
for role_id in data['roles']:
role = utils.find(lambda r: r.id == role_id, self.roles)
if role is not None:
@@ -149,13 +148,15 @@ class Server(EqualityComparable):
for obj in guild.get('voice_states', []):
self._update_voice_state(obj)
def get_default_role(self):
@utils.cached_property
def default_role(self):
"""Gets the @everyone role that all members have by default."""
return utils.find(lambda r: r.is_everyone(), self.roles)
return utils.find(lambda r: r.is_everyone, self.roles)
def get_default_channel(self):
@utils.cached_property
def default_channel(self):
"""Gets the default :class:`Channel` for the server."""
return utils.find(lambda c: c.is_default_channel(), self.channels)
return utils.find(lambda c: c.is_default, self.channels)
@property
def icon_url(self):