matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Fix crash on duplicate or out of order reactions.

Browse Source 
Eventual consistency ftw
This commit is contained in:
khazhyk 2016-11-23 21:51:43 -08:00 committed by Rapptz
parent 59d17e4137
commit c8fd8a9e1a
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
discord/state.py
View File

@ -287,8 +287,11 @@ class ConnectionState:
emoji = self._get_reaction_emoji(**data['emoji']) emoji = self._get_reaction_emoji(**data['emoji'])
reaction = utils.get(message.reactions, emoji=emoji) reaction = utils.get(message.reactions, emoji=emoji)
# if reaction isn't in the list, we crash. This means discord # Eventual consistency means we can get out of order or duplicate removes.
# sent bad data, or we stored improperly if not reaction:
log.warning("Unexpected reaction remove {}".format(data))
return
reaction.count -= 1 reaction.count -= 1
if data['user_id'] == self.user.id: if data['user_id'] == self.user.id:
reaction.me = False reaction.me = False