matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Create Permissions and Colour objects when necessary in Role

Browse Source 
This should have some memory savings of ~24 bytes per role.

* 8 bytes for Permissions
* 8 bytes for Colour
* 8 bytes for the alias

I'm not sure how significant it is but it should be a decent amount.
This commit is contained in:
Rapptz 2019-08-27 18:34:40 -04:00
parent 828e8189d3
commit 5c0b127c96
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
discord/role.py
View File

@ -73,12 +73,8 @@ class Role(Hashable):
The ID for the role. The ID for the role.
name: :class:`str` name: :class:`str`
The name of the role. The name of the role.
permissions: :class:`Permissions`
Represents the role's permissions.
guild: :class:`Guild` guild: :class:`Guild`
The guild the role belongs to. The guild the role belongs to.
colour: :class:`Colour`
Represents the role colour. An alias exists under ``color``.
hoist: :class:`bool` hoist: :class:`bool`
Indicates if the role will be displayed separately from other members. Indicates if the role will be displayed separately from other members.
position: :class:`int` position: :class:`int`
@ -91,7 +87,7 @@ class Role(Hashable):
Indicates if the role can be mentioned by users. Indicates if the role can be mentioned by users.
""" """
__slots__ = ('id', 'name', 'permissions', 'color', 'colour', 'position', __slots__ = ('id', 'name', '_permissions', '_colour', 'position',
'managed', 'mentionable', 'hoist', 'guild', '_state') 'managed', 'mentionable', 'hoist', 'guild', '_state')
def __init__(self, *, guild, state, data): def __init__(self, *, guild, state, data):
@ -144,18 +140,29 @@ class Role(Hashable):
def _update(self, data): def _update(self, data):
self.name = data['name'] self.name = data['name']
self.permissions = Permissions(data.get('permissions', 0)) self._permissions = data.get('permissions', 0)
self.position = data.get('position', 0) self.position = data.get('position', 0)
self.colour = Colour(data.get('color', 0)) self._colour = data.get('color', 0)
self.hoist = data.get('hoist', False) self.hoist = data.get('hoist', False)
self.managed = data.get('managed', False) self.managed = data.get('managed', False)
self.mentionable = data.get('mentionable', False) self.mentionable = data.get('mentionable', False)
self.color = self.colour
def is_default(self): def is_default(self):
"""Checks if the role is the default role.""" """Checks if the role is the default role."""
return self.guild.id == self.id return self.guild.id == self.id
@property
def permissions(self):
""":class:`Permissions`: Returns the role's permissions."""
return Permissions(self._permissions)
@property
def colour(self):
""":class:`Colour`: Returns the role colour. An alias exists under ``color``."""
return Colour(self._colour)
color = colour
@property @property
def created_at(self): def created_at(self):
""":class:`datetime.datetime`: Returns the role's creation time in UTC.""" """:class:`datetime.datetime`: Returns the role's creation time in UTC."""