matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Remove calls to gc.collect in ConnectionState

Browse Source 
For some bots this was actually a performance bottleneck, might as
well remove it if it causes bad performance
This commit is contained in:
Rapptz 2021-07-05 21:41:32 -04:00
parent 99b8ae35ba
commit 03cd6ff433
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
discord/state.py
View File

@ -32,7 +32,6 @@ from typing import Dict, Optional
import weakref import weakref
import warnings import warnings
import inspect import inspect
import gc
import os import os
@ -215,11 +214,6 @@ class ConnectionState:
self._private_channels_by_user = {} self._private_channels_by_user = {}
self._messages = self.max_messages and deque(maxlen=self.max_messages) self._messages = self.max_messages and deque(maxlen=self.max_messages)
# In cases of large deallocations the GC should be called explicitly
# To free the memory more immediately, especially true when it comes
# to reconnect loops which cause mass allocations and deallocations.
gc.collect()
def process_chunk_requests(self, guild_id, nonce, members, complete): def process_chunk_requests(self, guild_id, nonce, members, complete):
removed = [] removed = []
for key, request in self._chunk_requests.items(): for key, request in self._chunk_requests.items():
@ -332,10 +326,6 @@ class ConnectionState:
del guild del guild
# Much like clear(), if we have a massive deallocation
# then it's better to explicitly call the GC
gc.collect()
@property @property
def emojis(self): def emojis(self):
return list(self._emojis.values()) return list(self._emojis.values())
@ -1396,14 +1386,6 @@ class AutoShardedConnectionState(ConnectionState):
self.dispatch('connect') self.dispatch('connect')
self.dispatch('shard_connect', data['__shard_id__']) self.dispatch('shard_connect', data['__shard_id__'])
# Much like clear(), if we have a massive deallocation
# then it's better to explicitly call the GC
# Note that in the original ready parsing code this was done
# implicitly via clear() but in the auto sharded client clearing
# the cache would have the consequence of clearing data on other
# shards as well.
gc.collect()
if self._ready_task is None: if self._ready_task is None:
self._ready_task = asyncio.create_task(self._delay_ready()) self._ready_task = asyncio.create_task(self._delay_ready())